: python: actor: shutdown_context() terminates this_host() #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89498869. |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Dec 18, 2025
…rch#2178) Summary: now `shutdown_context()` terminates the OS process running `this_host()`. Differential Revision: D89498869
shayne-fletcher
force-pushed
the
export-D89498869
branch
from
617b2e4 to
800ff5b
Compare
Summary: D89052078 changed the implementation of `shutdown_context()` but unfortunately as written it can't work and generates a runtime error: "cannot shut down `HostMesh` that is a reference instead of owned". skip the explicit shutdown while we work out a better fix. Reviewed By: colin2328 Differential Revision: D89478006
Summary: reinstate `this_host` host-mesh shutdown (see D89478006 for why we turned it off) Differential Revision: D89495607
…rch#2178) Summary: now `shutdown_context()` terminates the OS process running `this_host()`. Differential Revision: D89498869
shayne-fletcher
force-pushed
the
export-D89498869
branch
from
800ff5b to
db3aff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: now
shutdown_context()terminates the OS process runningthis_host().Differential Revision: D89498869