Create a Perfetto Sink #2169
Open
Create a Perfetto Sink #2169
+678
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89403329. |
thomasywang
force-pushed
the
export-D89403329
branch
from
d64bdd8 to
2811d8a
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 18, 2025
Summary: Pull Request resolved: meta-pytorch#2169 Create a TraceDispatcherSink that writes perfetto traces in their native protobuf format directly to local files The advantages include: - No row limits (vs 400k for a scuba query) - Zero ingestion latency (Traces are available immediately) - No json -> protobuf conversion needed and very compact - Compatibility with distributed file systems like OILFS - Faster execution of expanse: No more querying scuba and conversion of scuba -> perfetto protobuf Differential Revision: D89403329
thomasywang
force-pushed
the
export-D89403329
branch
from
2811d8a to
ff38ecf
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 18, 2025
Summary: Create a TraceDispatcherSink that writes perfetto traces in their native protobuf format directly to local files The advantages include: - No row limits (vs 400k for a scuba query) - Zero ingestion latency (Traces are available immediately) - No json -> protobuf conversion needed and very compact - Compatibility with distributed file systems like OILFS - Faster execution of expanse: No more querying scuba and conversion of scuba -> perfetto protobuf Differential Revision: D89403329
thomasywang
force-pushed
the
export-D89403329
branch
2 times, most recently
from
5e779ae to
e372e60
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Dec 22, 2025
Summary: Create a TraceDispatcherSink that writes perfetto traces in their native protobuf format directly to local files The advantages include: - No row limits (vs 400k for a scuba query) - Zero ingestion latency (Traces are available immediately) - No json -> protobuf conversion needed and very compact - Compatibility with distributed file systems like OILFS - Faster execution of expanse: No more querying scuba and conversion of scuba -> perfetto protobuf Reviewed By: moonli Differential Revision: D89403329
Summary: Create a TraceDispatcherSink that writes perfetto traces in their native protobuf format directly to local files The advantages include: - No row limits (vs 400k for a scuba query) - Zero ingestion latency (Traces are available immediately) - No json -> protobuf conversion needed and very compact - Compatibility with distributed file systems like OILFS - Faster execution of expanse: No more querying scuba and conversion of scuba -> perfetto protobuf Reviewed By: moonli Differential Revision: D89403329
thomasywang
force-pushed
the
export-D89403329
branch
from
e372e60 to
d41e9ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create a TraceDispatcherSink that writes perfetto traces in their native protobuf format directly to local files
The advantages include:
Differential Revision: D89403329