tmp: add a local job for testing #2155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: In the Lightning integration, there is a need that we want to explicitly to config the client and worker hosts to: 1. use public IP address and an explicit port as the `Host`'s frontend address; 2. bind the port to INADDR_ANY, since AWS does not allow the port being bound to the public IP address. In order to enable this configuration, this diff adds a new variant, `Alias` to channel. This variant provides 2 fields: 1. dial_to, which can be used by Lightning to set as the public IP address. 2. bind_to, which is used to specify how to bind the port. It is Lightning's responsibility to ensure the network is configured in a way that the packages sent to `dial_to` would be routed to `bind_to`. Reviewed By: mariusae Differential Revision: D89190085
Summary: As explained in D89190085, Lightning wants to explicitly set the frontend address both client and worker hosts. Since the client's frontend address is controlled through `enable_transport`, this diff adds a new enum BindSpec, and plumb it to `enable_transport`, so the user can pass an explicit address string to do that. Differential Revision: D89190087
Summary: This builds on the previous change to implement a *real* in-process host and local proc mesh. Thus, nothing is fake anymore in the v1 path: this_proc() behaves the same everywhere, and is managed in precisely the same way. This also means that we can do things like hand out references to the local host (or proc), and have remove actors spawn (procs, actors) on it! It will also simplify integration: since the client proc is now a host, it has a single front-end address that multiplexes all its procs (including the local one). We keep around the old codepaths for the benefit of v0; this can be significantly simplified again once we drop v0 support. Differential Revision: D89196041
Summary: Pull Request resolved: meta-pytorch#2155 Differential Revision: D89195085
pzhan9
force-pushed
the
export-D89195085
branch
from
12e2a00 to
37be47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D89195085