Skip to content

Fixed network stream reading #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebentern merged 1 commit into from
Sep 11, 2025
Merged

Fixed network stream reading #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Meshtastic/Connections/TcpConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,16 @@ public override async Task ReadFromRadio(Func<FromRadio, DeviceStateContainer, T
if (networkStream == null)
throw new ApplicationException("Could not establish network stream");

var buffer = new byte[DEFAULT_BUFFER_SIZE];
while (networkStream.CanRead)
{
await networkStream.ReadExactlyAsync(buffer);
foreach (var item in buffer)
var buffer = new byte[DEFAULT_BUFFER_SIZE];
int bytesRead = await networkStream.ReadAsync(buffer, 0, buffer.Length);
while (bytesRead > 0)
{
for (int i = 0; i < bytesRead; i++)
{
if (await ParsePackets(item, isComplete))
if (await ParsePackets(buffer[i], isComplete))
return;
}
bytesRead = await networkStream.ReadAsync(buffer, 0, buffer.Length);
}
}

Expand Down
Loading