Skip to content

Fallback to using pitch if CTD data were not logged. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MBARIMike merged 1 commit into from
Jan 18, 2026
Merged

Fallback to using pitch if CTD data were not logged. #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@
// Testing for making 2column plot work with process_lrauv from an MBTS log_file
//"args": ["-v", "1", "--log_file", "daphne/missionlogs/2025/20250721_20250723/20250721T211348/202507212114_202507222147.nc4", "--no_cleanup"]
// A log_file showing temperature not looking right in stoqs_lrauv_jul2024_t, as shared on Slack plankton-proxies on 11 Dec 2025
"args": ["-v", "1", "--log_file", "pontus/missionlogs/2024/20240715_20240725/20240723T023501/202407230235_202407232319.nc4", "--no_cleanup"]
//"args": ["-v", "1", "--log_file", "pontus/missionlogs/2024/20240715_20240725/20240723T023501/202407230235_202407232319.nc5", "--no_cleanup"]
// scipy.spatial._qhull.QhullError: QH6013 qhull input error: input is less than 3-dimensional since all points have the same x coordinate 0
//"args": ["-v", "1", "--log_file", "pontus/missionlogs/2024/20240715_20240725/20240724T221410/202407242214_202407242314.nc4", "--no_cleanup"]
// All 2025 LRAUV log files - fails with --log_file ahi/missionlogs/2025/20250128_20250131/20250129T223350/202501292233_202501292247.nc4
Expand All @@ -444,6 +444,8 @@
//"args": ["-v", "1", "--log_file", "aku/missionlogs/2025/20250205_20250206/20250206T003902/202502060039_202502060040.nc4", "--no_cleanup"]
// ValueError: x and y must have same first dimension, but have shapes (45804,) and (14539,)
//"args": ["-v", "1", "--log_file", "makai/missionlogs/2025/20251006_20251014/20251010T133000/202510101330_202510110214.nc4", "--no_cleanup"]
// Mission without CTD data - test usng pitch
"args": ["-v", "1", "--log_file", "makai/missionlogs/2025/20250306_20250314/20250314T133305/202503141333_202503141735.nc4", "--no_cleanup"]
},

]
Expand Down
8 changes: 7 additions & 1 deletion src/data/resample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,14 @@ def _get_pitch_corrected_instrument(self) -> str:
# is not fine enough for resampling to 1 second intervals without
# introducing NaNs. Therefore, we will do minimal interpolation
# (up to MAX_INTERPOLATE_LIMIT consecutive NaNs) after resampling.
# In order to have all deployments processed fallback to pitch.
if self.log_file:
candidates = ["ctdseabird", "ctdseabird_sea_water_temperature", "ctdneilbrown"]
candidates = [
"ctdseabird",
"ctdseabird_sea_water_temperature",
"ctdneilbrown",
"universals_platform_pitch_angle",
]
else:
candidates = ["ctd1", "seabird25p"]

Expand Down