Open
Conversation
maxistar
reviewed
Aug 16, 2022
| <color name="colorPrimaryDark">#303F9F</color> | ||
| <color name="colorAccent">#404081</color> | ||
| <color name="colorIcon">#7F7F7F</color> | ||
| <color name="menuIconColor">#fff</color> |
Owner
There was a problem hiding this comment.
The reason I made it grey if there is not enough space for the search and edit icon the icon will appear in the options menu and it is going to be invisible because it will be white on white background. I think in android should be another solution for this problem but I do not exactly know which one.
Author
There was a problem hiding this comment.
The grey icons don't look good at all. Also, there is always going to me enough space for those two icons even in smaller screen size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The icon color of the search and edit icons was incorrect, so I fixed it.