This repository was archived by the owner on Sep 26, 2024. It is now read-only.
Updated documentation for the ConfigFormNotesInterface usages.#214
Open
shinde-rahul wants to merge 3 commits intomautic:mainfrom
Open
Updated documentation for the ConfigFormNotesInterface usages.#214shinde-rahul wants to merge 3 commits intomautic:mainfrom
shinde-rahul wants to merge 3 commits intomautic:mainfrom
Conversation
shinde-rahul
commented
Oct 11, 2022
shinde-rahul
commented
- The integration bundle ConfigFormNotesInterface usages.
Author
|
@escopecz @kuzmany @RCheesley Please review. |
escopecz
reviewed
Oct 11, 2022
| use Mautic\IntegrationsBundle\Integration\Interfaces\ConfigFormSyncInterface; | ||
| use Mautic\IntegrationsBundle\Mapping\MappedFieldInfoInterface; | ||
| use Mautic\IntegrationsBundle\Sync\SyncDataExchange\Internal\Object\Company; | ||
| use Mautic\IntegrationsBundle\Sync\SyncDataExchange\Internal\Object\Contact; |
Member
There was a problem hiding this comment.
Although the use statements are quite long and for example this one is not used. Can you remove the unused ones?
Member
|
Thanks for the PR @shinde-rahul - please can you also raise it on the WIP new docs if you have a moment - I think this is the relevant page: https://github.com/mautic/developer-documentation-new/blob/main/docs/plugins/config.rst which can be previewed at https://mautic-developer.readthedocs.io/en/latest/plugins/config.html. Important note: If this only applies to 5.x please make the PR on the 5.x branch of the docs, previewed here: https://mautic-developer.readthedocs.io/en/5.x/plugins/config.html. Thanks! |
escopecz
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.