This repository was archived by the owner on Sep 26, 2024. It is now read-only.
POST/PUT/PATCH email api translation parent#140
Open
PurHur wants to merge 2 commits intomautic:mainfrom
Open
Conversation
In the backend the children are always fetched via the `parent->getTranslationChildren`
This commit is related to #7064 . Beside this commit replaces `page` with `email`.
npracht
changed the title
Author
|
Please hit me if yout need something from me. Sadly i dont use mautic anymore (great software by the way!!!), so i dont have a lot of time anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened this PR for a discussion.
mautic/mautic#7604 pointed out that you dont have to specify
translationParentbuttemplateTranslationParentORsegmentedTranslationParentinstead. This works on the current 2.16 release fine.Beside that,
translationChildrenare not evaluated because the backend always calls$parent->getTranslationChildren().How would i document that different variable name depended on emailType? If i have a "nicer" solution i will create a fresh clean PR.