Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
=========================================
Coverage 52.49% 52.49%
Complexity 390 390
=========================================
Files 30 30
Lines 1042 1042
=========================================
Hits 547 547
Misses 495 495 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@kuzmany it shouldn't look good, see the description :) this should be addressed in mautic/mautic, so this change isn't needed |
Member
|
Ah, okay I have to check it. |
Member
|
Converting this to draft given we don't actually need to do anything with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mautic/mautic#12813 some logic changed, and it is now required to pass the
PostActionin the payload offormAPI calls.IMO this is a breaking change, and the default on the Mautic should change to something that is compatible with the previous flow.
If we want to change that default, it needs to be done in M6.
This PR is purely meant to show where the issue with the tests is located, not to be merged.