remove seaborn and related functions, add matplotlib as an optional dep #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathurinm
approved these changes
Apr 23, 2025
Owner
mathurinm
left a comment
mathurinm
left a comment
There was a problem hiding this comment.
LGTM, thanks @samuelstjean
Do you need a release or are you satisfied with this being in the dev version ?
Owner
|
Failure is related to codecov, not to tests. Merging |
Contributor
Author
|
No worries, I can just use that as is for now on my side. |
Contributor
Author
|
Manually running pytest as is on my side was throwing some errors, I guess the online version takes care of some extra things so it's a non issue I guess as it passes here after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, this should do it, the example I was talking about now runs. I also added matplotlib to the optional dependencies.
Local tests seems to run, but some are broken from other things so that might need more considerations.