Add note about streaming server error responses#1775
Open
mjankowski wants to merge 1 commit intomastodon:mainfrom
Open
Add note about streaming server error responses#1775mjankowski wants to merge 1 commit intomastodon:mainfrom
mjankowski wants to merge 1 commit intomastodon:mainfrom
Conversation
Contributor
|
I’m not sure this is correct, what I was seeing before (assuming this is still the case) was not an HTTP 4XX response, but just the JSON body sent over the websocket protocol. |
Contributor
|
IIRC how I encountered this before, more specifically, was:
|
4af1003 to
6a90a52
Compare
Contributor
Author
|
Good overview -- tried to add some nuance around those separate types of errors (which both share that |
6a90a52 to
945dcf4
Compare
945dcf4 to
8a134ad
Compare
8a134ad to
dcbd064
Compare
dcbd064 to
3e9191a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1505
This is just attempting to solve the "we literally only mention event responses and don't contemplate errors" aspect of that page. Possible future improvement here would be to more exhaustively list error conditions?