Added vertical switching if height more than weight#92
Open
d8corp wants to merge 3 commits intomarkusenglund:masterfrom
Open
Added vertical switching if height more than weight#92d8corp wants to merge 3 commits intomarkusenglund:masterfrom
d8corp wants to merge 3 commits intomarkusenglund:masterfrom
Conversation
d8corp
changed the title
Owner
|
Hi, Your changes look well thought out and the demo works well. However, I'm leaning towards not merging. A vertical toggle-switch is as far as I know a very rare use-case and adding support for it might not be worth the additional complexity it brings and supporting it forever. I would be open to merging this if you or someone else can make a convincing argument that a vertical switch is not a niche use-case and in fact something a lot of users of this library want. |
Author
|
I completely agree with you. The vertical swipe for UI elements is an antipattern. I just look for some new UX, try different things. Just some food for your brain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added correct behavior if height more than weight, it does not change interfaces.