Skip to content

fix a bug with polylines exporting a part per coordinate #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rfecher wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix a bug with polylines exporting a part per coordinate #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions src/poly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,36 @@ module.exports.extent = function(coordinates) {
};

function parts(geometries, TYPE) {
var no = 1;
if (TYPE === types.geometries.POLYGON || TYPE === types.geometries.POLYLINE) {
no = geometries.reduce(function (no, coords) {
no += coords.length;
if (Array.isArray(coords[0][0][0])) { // multi
no += coords.reduce(function (no, rings) {
return no + rings.length - 1; // minus outer
}, 0);
}
return no;
var no = 1;
if (TYPE === types.geometries.POLYGON || TYPE === types.geometries.POLYLINE) {
no = geometries.reduce(function (no, coords) {
no += coords.length;
if (Array.isArray(coords[0][0][0])) { // multi
no += coords.reduce(function (no, rings) {
return no + rings.length - 1; // minus outer
}, 0);
}
// For LineString: coords is [[x1,y1], [x2,y2], ...] - this is 1 part
// For MultiLineString: coords is [[[x1,y1], [x2,y2]], [[x3,y3], [x4,y4]]] - multiple parts
// For Polygon: coords is [[[outer ring]], [[hole1]], [[hole2]]] - multiple parts
if (Array.isArray(coords[0]) && Array.isArray(coords[0][0])) {
// Check if this is a multi-geometry or polygon with holes
if (Array.isArray(coords[0][0][0])) {
// Multi-geometry: each element is a separate part
no += coords.length;
// For multi-polygons, also count inner rings
no += coords.reduce(function (innerNo, rings) {
return innerNo + rings.length - 1; // minus outer ring
}, 0);
} else {
// Simple LineString or Polygon outer ring: 1 part
no += 1;
}
} else {
// Fallback: 1 part
no += 1;
}
return no;
}, 0);
return no;
}

Expand Down