Works around internal PyTorch bug related to shared weights#96
Merged
daniel-j-h merged 1 commit intomasterfrom Aug 2, 2018
Merged
Works around internal PyTorch bug related to shared weights#96daniel-j-h merged 1 commit intomasterfrom
daniel-j-h merged 1 commit intomasterfrom
Conversation
Collaborator
Author
|
This needs a release with major version bump since we are breaking the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyTorch tracing model exporter has an issue with shared weights / refs to layers, see
pytorch/pytorch#8392
The workaround is to not store any refs to the resnet layers in the model itself. Instead we have to directly pull the input tensors through the resnet layers in the forward pass.
This will change the
.pthfile format. We could work around that by loading the serialized state dict in non-strict fashion in the export tool. But then we are opening up the door to letting actual errors going through.Note: we need to fix the FPN pull request in a similar way #75
cc @bkowshik @maning