Fix phenotype data path construction and remove hardcoded release version #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues in phenotype data loading caused by malformed paths and a hardcoded release version:
Path construction
Previously, phenotype paths were built using string concatenation:
base_phenotype_path = f"{self._url}v3.2/phenotypes/all"
This produced malformed paths (missing /) in cloud environments and worked only locally due to file caching.
Now uses posixpath.join to ensure proper path formatting across GCS and other filesystems.
Hardcoded release version (v3.2)
The hardcoded version caused breakage when new data releases (e.g., v3.3) became available.
Now uses a dynamic self.release attribute (default fallback v3.2) to make the code forward-compatible.
Updated methods
_load_phenotype_data
phenotype_sample_sets