Explicitly import reduce from functools #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minor change is intended to make library run error free in Python 3. Python 3 dropped support for reduce() without using functools. Reduce() is available in functools in Python2 as well. https://docs.python.org/2/library/functools.html#functools.reduce "This is the same function as reduce(). It is made available in this module to allow writing code more forward-compatible with Python 3."
Contributor
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor change is intended to make library run error free in Python 3.
Python 3 dropped support for reduce() without using functools.
Reduce() is available in functools in Python2 as well.
https://docs.python.org/2/library/functools.html#functools.reduce
"This is the same function as reduce(). It is made available in this module to allow writing code more forward-compatible with Python 3."
Lack of this will throw an error in Python 3 : NameError: name 'reduce' is not defined