Skip to content

fix: Pause mediaContentTimeSpent when logMediaContentEnd is triggered #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mansi-mParticle merged 5 commits into from
Mar 28, 2025
Merged

fix: Pause mediaContentTimeSpent when logMediaContentEnd is triggered #70

Mansi-mParticle merged 5 commits into from
Mar 28, 2025

Conversation

@mmustafa-tse
Copy link
Contributor

@mmustafa-tse mmustafa-tse commented Mar 26, 2025

Summary

  • When a logMediaContentEnd event is called, it does not stop the counter for mediaContentTimeSpent Therefore, even when the consumer finishes content but doesn't complete the media session, the mediaContentTimeSpent counter increases. Currently, only logPause and logMediaSessionEnd will stop the mediaContentTimeSpent counter. This pr is to allow the mediaContentTimeSpent to be paused when a logMediaContentEnd is triggered

Testing Plan

  • Was this tested locally? If not, explain why.
  • E2E and unit tested

Reference Issue

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

BrandonStalnaker
BrandonStalnaker approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mansi-mParticle
Mansi-mParticle approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle merged commit 497af13 into mParticle:main Mar 28, 2025
4 checks passed
mparticle-automation added a commit that referenced this pull request Mar 28, 2025
@mparticle-automation
chore: 1.5.5 (release)
2a3a225 
## [1.5.5](v1.5.4...v1.5.5) (2025-03-28)

### Bug Fixes

* Pause mediaContentTimeSpent when logMediaContentEnd is triggered ([#70](#70)) ([497af13](497af13))
@mparticle-automation
Copy link
Collaborator

mparticle-automation commented Mar 28, 2025

🎉 This PR is included in version 1.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@Mansi-mParticle Mansi-mParticle Mansi-mParticle approved these changes

@rmi22186 rmi22186 Awaiting requested review from rmi22186

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mmustafa-tse @mparticle-automation @BrandonStalnaker @Mansi-mParticle @massicottem