fix(blink.cmp): avoid duplicate characters#128
Draft
One-In-Dark wants to merge 1 commit intoluozhiya:masterfrom
Draft
fix(blink.cmp): avoid duplicate characters#128One-In-Dark wants to merge 1 commit intoluozhiya:masterfrom
One-In-Dark wants to merge 1 commit intoluozhiya:masterfrom
Conversation
Author
|
It's generated by Copilot so I can see that there's way too much noise :-( |
Problem: When fittencode is used as a source of blink.cmp, the characters following the cursor will be duplicated in the completion item. For example if the completion is triggered in "(|)" where the vertical bar '|' indicates the cursor, the completion item will be ")foo)", with an extra closing parenthesis in the beginning. Solution: Remove the logic that adds the following characters to the completion text, which should be only used for virtual text style. Closes luozhiya#127
Contributor
|
作者似乎好久没上线了哦 |
Author
看上去是的www, 没关系, 我也是拿它体验下 Copilot 写代码 (OpenCode 具体地说) 效果如何 :v |
Owner
|
在线呢，最近是事情比较多，回复不及时哈。之后我还打算有时间的话重构写个新版 😁 blink 这个插件我不太熟悉， @One-In-Dark @cxwx 这个pr你们测过效果怎么样 |
Contributor
问题是没了，但本来会跳出来的补全也没了 |
Author
|
先 draft 一会儿, 我一定会回来的😤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When fittencode is used as a source of blink.cmp, the characters following the cursor will be duplicated in the completion item.
For example if the completion is triggered in "(|)" where the vertical bar '|' indicates the cursor, the completion item will be ")foo)", with an extra closing parenthesis in the beginning.
Solution:
Remove the logic that adds the following characters to the completion text, which should be only used for virtual text style.
Closes #127