Improve performance of iterative sigma clipped rms#259
Merged
darafferty merged 1 commit intolofar-astron:masterfrom Jul 23, 2025
Merged
Improve performance of iterative sigma clipped rms#259darafferty merged 1 commit intolofar-astron:masterfrom
darafferty merged 1 commit intolofar-astron:masterfrom
Conversation
Sort the array first, then reuse for both median calculation and finding the clipped subset
darafferty
approved these changes
Jul 23, 2025
Collaborator
darafferty
left a comment
darafferty
left a comment
There was a problem hiding this comment.
Thanks for the MR. It looks good to me -- very nice optimization!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the array first, then reuse for both median calculation and finding the clipped subset