Open
Conversation
Owner
|
@Neel-Shah-29 : can you please fix these conflict so I can test the Reduce operator ? |
Neel-Shah-29
force-pushed
the
Reduce-Operator-1
branch
from
f675d07 to
f04107f
Compare
Author
Done with the changes sir now you can review it once |
Owner
|
@Neel-Shah-29 : can you please fix the conflicts with respect to the new master ? |
lmoneta
reviewed
Aug 16, 2022
Neel-Shah-29
force-pushed
the
Reduce-Operator-1
branch
from
f04107f to
a0f2f3d
Compare
lmoneta
reviewed
Aug 16, 2022
Owner
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
I have some comments on fixing the generated code.
lmoneta
reviewed
Aug 16, 2022
Author
|
Done with the changes sir but i am facing some errors with the generated code as mentioned in the image below. |
…hape in the Reduce Operator
Fix also correct namespace for reference output in reduce tests
Neel-Shah-29
force-pushed
the
Reduce-Operator-1
branch
from
b32397f to
75d47d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #