Add an upper bound pin for setuptools
#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This is necessary because scraper depends on vsts, which itself imports the pkg_resources package from setuptools in its __init__.py. The pkg_resources package will be removed in setuptools 81, which will fundamentally break vsts. I would make the change in vsts instead, but that project has changed its name and has undergone several major revisions since: - https://pypi.org/project/vsts/ (see in particular the homepage link) - https://github.com/microsoft/azure-devops-python-api
jsf9k
force-pushed
the
improvement/add-upper-bound-pin-for-setuptools
branch
from
5b83345 to
8152cc8
Compare
Contributor
Author
LRWeber
approved these changes
Jan 20, 2026
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because
scraperdepends onvsts, which itself imports thepkg_resourcespackage fromsetuptoolsin its__init__.py. Thepkg_resourcespackage will be removed insetuptools81, which will fundamentally breakvstsand thereforescraper.I would make the change in
vstsinstead, but that project has changed its name and has undergone several major revisions since:vstson PyPI (see in particular the homepage link, which redirects to the link in the following bullet)vstson GitHubAn alternative would be to replace
vstswith a more modern dependency that serves the same purpose.vstshasn't seen any updates in seven years.