-
Notifications
You must be signed in to change notification settings - Fork 121
Add event struct; add events field to AgentDeployment #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Created using jj-spr 0.1.0
|
|
ref AP-271 |
| string mem_limit = 11; | ||
| string cpu_limit = 12; | ||
| string server_region = 13; | ||
| repeated AgentEvent events = 14; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected to be consumed by livekit-cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we have observability events support coming soon, should we just log the events for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, the code is not final but it's consumed here https://github.com/livekit/livekit-cli/pull/753/files#diff-4a70574ec74b4fc8888fd29a16e49065fec8bd1833148322247a5522810a1c89R845
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoonsio who is leading this? Let me speak with them to understand if it can fit our use case. We could be publishing quite a decent QPS in the future, so it would need to handle that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is necessary to show events via livekit-cli given that it can be noisy with crashlooping pods. I think displaying aggregated status should be enough and we can follow up with separate API to show the events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ask in #project-agent-observability channel.
No description provided.