chore: cleanup deprecated codes #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up unused ComboMode enum and associated code that was previously used for bash_xtrace mode support. The mode functionality has been deprecated and is no longer needed in the current codebase. Changes: - Remove ComboMode enum definition and Display implementation - Remove mode field from ComboMetadata struct - Update test fixtures to no longer include mode field - Clean up imports and type references in starter module This simplifies the codebase by removing unused functionality and reducing maintenance overhead.
Clean up StarterError enum by removing the Timeout variant that is no longer used in the codebase. The timeout functionality has been deprecated and the associated error case is no longer needed. This simplifies the error handling and reduces maintenance overhead by eliminating unused code paths.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #70 +/- ##
======================================
Coverage ? 59.63%
======================================
Files ? 76
Lines ? 15388
Branches ? 0
======================================
Hits ? 9177
Misses ? 6211
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.