feat: support passing arguments to combo starters in TUI #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend ComboAction::Execute to include args parameter - Update CLI argument parsing to accept trailing varargs for combo run command - Add shell escaping utilities for safe command line display - Display executed command line with syntax highlighting in combo UI - Pass args through to StarterCommand execution - Update tests to include command_line field in ComboEvent::Executing
- Add `resolve_command_display` to show relative paths for workspace combos - Enhance command line rendering with shell prompt and proper padding - Fix layout calculations for command display area with prompt spacing - Update tests to reflect new height calculations with padding
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #69 +/- ##
======================================
Coverage ? 59.62%
======================================
Files ? 77
Lines ? 15398
Branches ? 0
======================================
Hits ? 9181
Misses ? 6217
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove shell escaping logic that was overly complex for display purposes - Simplify format_command_line to just join command and args with spaces - Keep resolve_command_display for workspace path normalization - Maintain same functionality while reducing code complexity
- Update height calculation for collapsed combos to include command display area - Render command line in collapsed state to maintain consistency with expanded view - Ensure users can see executed command even when combo output is collapsed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.