fix: prevent blocking on non-utf8 output in coco record and enhance exec reliability #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to read_until() and lossy UTF-8 decoding so child output containing non-utf8 bytes does not terminate the reader and cause backpressure/hangs. Key changes: - Use BufReader::read_until(b'\n', &mut buf) instead of lines().next_line() - Add take_line() to normalize \n/\r\n and decode via from_utf8_lossy - Count raw bytes for buffer limits and keep existing flush behavior
Add warning logs when read_until() fails on stdout/stderr streams in exec command. This improves debugging visibility for child process output reading errors.
Remove redundant formatting guidelines and consolidate prompt instructions to focus on core requirements. The commit message generation logic remains unchanged while reducing noise in the prompt template.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #68 +/- ##
======================================
Coverage ? 59.89%
======================================
Files ? 77
Lines ? 15253
Branches ? 0
======================================
Hits ? 9136
Misses ? 6117
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a blocking issue in
coco recordwhen handling child process output containing non-UTF-8 bytes, improves exec command reliability with better logging, and simplifies commit.sh prompt instructions.