feat: fix linux kernel 6.18 building problem#204
feat: fix linux kernel 6.18 building problem#204gfdgd-xi wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
Signed-off-by: gfdgd_xi <3025613752@qq.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the module-local init_mnt_ns() helper to init_mnt_ns_data() and updates its log message and caller to avoid symbol name conflicts with the Linux 6.18 kernel headers while preserving existing behavior. Class diagram for renamed init_mnt_ns helper functionclassDiagram
class VfsKretprobesModule {
<<module>>
- struct mnt_namespace* target_mnt_ns
- int init_mnt_ns_data()
+ int init_vfs_kretprobes(void vfs_changed_func)
}
VfsKretprobesModule : init_vfs_kretprobes() calls init_mnt_ns_data()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gfdgd-xi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @gfdgd-xi. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider choosing a more descriptive function name than
init_mnt_ns_data(e.g., indicating it initializestarget_mnt_nsor is a workaround for kernel 6.18) to make its role clearer and distinguish it from the kernel symbol by intent, not just by suffix. - It may help future maintainers to add a brief comment near the function definition explaining that the rename is specifically to avoid the
init_mnt_nssymbol collision introduced in Linux kernel 6.18.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider choosing a more descriptive function name than `init_mnt_ns_data` (e.g., indicating it initializes `target_mnt_ns` or is a workaround for kernel 6.18) to make its role clearer and distinguish it from the kernel symbol by intent, not just by suffix.
- It may help future maintainers to add a brief comment near the function definition explaining that the rename is specifically to avoid the `init_mnt_ns` symbol collision introduced in Linux kernel 6.18.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
因为 6.18 内核头文件已定义
init_mnt_ns与 dkms 内的init_mnt_ns函数发生冲突导致编译不过,故修改init_mnt_ns函数名以规避该问题Summary by Sourcery
Bug Fixes: