fix: Update layout and icon size in AlbumTitle.qml#369
Merged
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom Sep 16, 2025
Merged
fix: Update layout and icon size in AlbumTitle.qml#369deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
Conversation
- Adjusted topMargin and leftMargin for the showHideleftSidebarButton. - Changed width and height of the button and icon for better alignment. - Updated the icon dimensions for improved visual consistency. Log: fix bug Bug: https://pms.uniontech.com/bug-view-332365.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactored layout margins and explicit dimensions for showHideleftSidebarButton and its icon in AlbumTitle.qml, replacing dynamic iconSize references for consistent UI alignment. Class diagram for updated showHideleftSidebarButton and icon propertiesclassDiagram
class showHideleftSidebarButton {
+int topMargin = 10
+int leftMargin = 10
+int width = 30
+int height = 30
+ToolTip.visible: bool
+ToolTip.text: string
}
class icon {
+string name = "topleft"
+int width = 16
+int height = 16
}
showHideleftSidebarButton o-- icon
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
- Updated version number in linglong.yaml files for all architectures. - Updated changelog to reflect the new version and included a fix for layout and icon size in AlbumTitle.qml. Log: update version
|
TAG Bot TAG: 6.0.45 |
deepin pr auto review根据提供的git diff,我来对这次更新进行审查: 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
改进建议:
width: iconSize
height: iconSize
* fix: Update layout and icon size in AlbumTitle.qml
- Adjusted margins for better spacing
- Fixed icon sizes for consistency
总体来说,这次更新主要是UI布局和图标的调整,属于常规的功能更新。代码质量良好,但需要注意保持UI元素的一致性。 |
lzwind
approved these changes
Sep 16, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kakueeen, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
Contributor
|
/retest |
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: fix bug
Bug: https://pms.uniontech.com/bug-view-332365.html
Summary by Sourcery
Fix alignment issues in the sidebar toggle button within AlbumTitle.qml by adjusting margins and standardizing button and icon sizes.
Bug Fixes: