Fixed [Issue #12] [Issue #16]#17
Open
BenEast wants to merge 3 commits intolinkedin:masterfrom
BenEast:master
Open
Fixed [Issue #12] [Issue #16]#17BenEast wants to merge 3 commits intolinkedin:masterfrom BenEast:master
BenEast wants to merge 3 commits intolinkedin:masterfrom
BenEast:master
Conversation
added 3 commits
July 3, 2017 15:57
…ption when input string contains the sub-string "//:@."
…ption when input string contains the sub-string "//:@."
…user:pass@host.com host.com' as input string Updated url-detector.processColon to set length to 0 when readUserPass(length) is true. All unit tests passed after this update.
|
@tzuhanjan will this be included? |
|
This PR seems to be missing tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--[Issue #12] Fixed StringIndexOutOfBoundsException when given 'http://user:pass@host.com host.com' as input string--
Updated url-detector.processColon to set length to 0 when readUserPass(length) is true.
All unit tests passed after this update.
--[Issue #16] Fixed StringIndexOutOfBoundsException when input string contains the substring "//:@."--
Updated conditional statements in url-detector.processColon() to clear the buffer if it has contents when readUserPass fails, and to set length to 0 otherwise.
This resolved Issue #16 regarding a StringIndexOutOfBoundsException being thrown when provided the input string "://VIVE MARINE LE PEN//:@.".
All unit tests still pass after this update.