wip(eslint-plugin): add a new invalid case and a lint against it, also include the rule in general config

Author: kresimir-coko

projects/eslint-plugin/rules/general/index.js

@@ -6,6 +6,7 @@
 module.exports = {
 	'array-is-array': require('./lib/rules/array-is-array'),
 	'destructure-requires': require('./lib/rules/destructure-requires'),
+	'blank-line-declaration-usage': require('./lib/rules/blank-line-declaration-usage'),
 	'empty-line-between-elements': require('./lib/rules/empty-line-between-elements'),
 	'expect-assert': require('./lib/rules/expect-assert'),
 	'group-imports': require('./lib/rules/group-imports'),

projects/eslint-plugin/rules/general/lib/rules/blank-line-declaration-usage.js

@@ -13,12 +13,21 @@ module.exports = {
 					if (nodeId.type === 'ArrayPattern') {
 						return nodeId.elements[0].name;
 					}
+					else if (nodeId.type === 'ObjectPattern') {
+						let nameArray = [];
+
+						nodeId.properties.map((property) =>
+							nameArray.push(property.key.name)
+						);
+
+						return nameArray;
+					}
 					else {
 						return nodeId.name;
 					}
 				};
 
-				if (!node.declarations.length) {
+				if (node.declarations.length < 1) {
 					return;
 				}
 
@@ -61,9 +70,22 @@ module.exports = {
 						nodeToCheckName = matchingArgument.name;
 					}
 				}
+				else if (node.declarations[0].id.type === 'ObjectPattern') {
+					const matchingArgument = variableName.find(
+						(name) =>
+							name ===
+							nodeToCheck.declarations[0].init.object.name
+					);
+
+					if (matchingArgument) {
+						nodeToCheckName = matchingArgument;
+					}
+				}
 				else {
-					nodeToCheckName =
-						nodeToCheck.declarations[0].init.object.name;
+					if (nodeToCheck.declarations[0].init.object) {
+						nodeToCheckName =
+							nodeToCheck.declarations[0].init.object.name;
+					}
 				}
 
 				if (nodeToCheckName === variableName) {

projects/eslint-plugin/rules/general/tests/lib/rules/blank-line-declaration-usage.js

@@ -66,6 +66,42 @@ ruleTester.run('blank-line-declaration-usage', rule, {
 				},
 			],
 		},
+		{
+			code: `
+				const obj = {
+					foo: 'bar',
+					bar: 'foo',
+					hi: 'bryce',
+				}
+			  	
+				const {foo} = obj;
+				const length = foo.length;
+			`,
+			errors: [
+				{
+					message: 'error msg',
+					type: 'VariableDeclaration',
+				},
+			],
+		},
+		{
+			code: `
+				const obj = {
+					foo: 'bar',
+					bar: 'foo',
+					hi: 'bryce',
+				}
+			  	
+				const {foo, bar, hi} = obj;
+				const length = hi.length;
+			`,
+			errors: [
+				{
+					message: 'error msg',
+					type: 'VariableDeclaration',
+				},
+			],
+		},
 	],
 	valid: [
 		{
@@ -86,5 +122,18 @@ ruleTester.run('blank-line-declaration-usage', rule, {
 				Object.keys(obj)
 			`,
 		},
+		{
+			code: `
+				const obj = {
+					foo: 'bar',
+					bar: 'foo',
+					hi: 'bryce',
+				}
+			  	
+				const {foo} = obj;
+				
+				const length = foo.length;
+			`,
+		},
 	],
 });