wip(eslint-plugin): add a new invalid case and a lint against it

Author: kresimir-coko

projects/eslint-plugin/rules/general/lib/rules/blank-line-declaration-usage.js

@@ -7,12 +7,22 @@ module.exports = {
 	create(context) {
 		return {
 			VariableDeclaration(node) {
+				const getNodeName = (node) => {
+					const nodeId = node.declarations[0].id;
+
+					if (nodeId.type === 'ArrayPattern') {
+						return nodeId.elements[0].name;
+					}
+					else {
+						return nodeId.name;
+					}
+				};
+
 				if (!node.declarations.length) {
 					return;
 				}
 
-				const variableName = node.declarations[0].id.name;
-
+				const variableName = getNodeName(node);
 				const variableDeclarationIndex = node.parent.body.indexOf(node);
 
 				const nodeToCheck =
@@ -40,6 +50,17 @@ module.exports = {
 						nodeToCheckName = matchingArgument.name;
 					}
 				}
+				else if (
+					nodeToCheck.declarations[0].init.type === 'TemplateLiteral'
+				) {
+					const matchingArgument = nodeToCheck.declarations[0].init.expressions.find(
+						(expression) => expression.name === variableName
+					);
+
+					if (matchingArgument) {
+						nodeToCheckName = matchingArgument.name;
+					}
+				}
 				else {
 					nodeToCheckName =
 						nodeToCheck.declarations[0].init.object.name;
@@ -62,7 +83,7 @@ module.exports = {
 			recommended: false,
 			url: 'https://github.com/liferay/eslint-config-liferay/issues/139',
 		},
-		fixable: 'code', // or "code" or "whitespace"
+		fixable: 'code',
 		schema: [],
 		type: 'problem',
 	},

projects/eslint-plugin/rules/general/tests/lib/rules/blank-line-declaration-usage.js

@@ -44,6 +44,28 @@ ruleTester.run('blank-line-declaration-usage', rule, {
 				},
 			],
 		},
+		{
+			code: `
+				function updateData() {
+					const obj = {
+						foo: 'bar',
+						bar: 'foo',
+						hi: 'bryce',
+					}
+
+					const formattedCategoryIds = Object.keys(obj).length
+						? 'superLongStringSoThatItForcesTheLineToBeWrapped'
+						: 'justASimpleString';
+					const APIUrl = \`${formattedCategoryIds}\`;
+				}
+			`,
+			errors: [
+				{
+					message: 'error msg',
+					type: 'VariableDeclaration',
+				},
+			],
+		},
 	],
 	valid: [
 		{