Open
Conversation
boris-kolpackov
requested changes
Jan 9, 2025
Contributor
boris-kolpackov
left a comment
boris-kolpackov
left a comment
There was a problem hiding this comment.
Additionally to the inline changes, I don't see you handling the new versions when generated.
Specifically, we need to decide whether they are strong. I think v6 and v7 are expected to be strong while v8 may not be.
I suggest that you grep the source for all uses of uuid_version and see if something needs to be added for new versions.
libstud/uuid/uuid.hxx
Outdated
| md5 = 3, // Name-based with MD5 hashing. | ||
| random = 4, // Randomly or pseudo-randomly generated. | ||
| sha1 = 5, // Name-based with SHA1 hashing. | ||
| reordered_time = 6, // Sortable Time-based (RFC9562) |
Contributor
There was a problem hiding this comment.
// Sortable time-based (RFC9562).
libstud/uuid/uuid.hxx
Outdated
| random = 4, // Randomly or pseudo-randomly generated. | ||
| sha1 = 5, // Name-based with SHA1 hashing. | ||
| reordered_time = 6, // Sortable Time-based (RFC9562) | ||
| unix_time = 7, // Privacy friendly time based (RFC9562) |
Contributor
There was a problem hiding this comment.
// Unix Epoch time-based (RFC9562).
libstud/uuid/uuid.hxx
Outdated
| sha1 = 5, // Name-based with SHA1 hashing. | ||
| reordered_time = 6, // Sortable Time-based (RFC9562) | ||
| unix_time = 7, // Privacy friendly time based (RFC9562) | ||
| custom = 8, // Custom vendor specific (RFC9562) |
Contributor
There was a problem hiding this comment.
// Custom format for experimental or vendor-specific use (RFC9562).
Also, please drop the comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the new UUID version added by RFC 9562.
Added new UUID version enumerations:
time_reordered(version 6): Introduces a sortable time-based UUID formattime_unix(version 7): Provides a privacy-friendly time-based UUID generation method using unix timecustom(version 8): Reserved for vendor-specific UUID implementations