Skip to content

Conversation

@adrianreber
Copy link
Contributor

No description provided.

@adrianreber adrianreber marked this pull request as draft December 30, 2024 13:56
Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber force-pushed the 2024-12-30-clang-format branch from 6446568 to d06d9f3 Compare December 30, 2024 13:57
@adrianreber
Copy link
Contributor Author

For testing I included a wrong indentation and the CI will print an error like this:


Run if [ -z "master" ]; then
  if [ -z "master" ]; then
    git fetch --deepen=1
    git clang-format --diff --style file --extensions c,h "HEAD~1"
  else
    git fetch origin master
    git clang-format --diff --style file --extensions c,h origin/master
  fi
  shell: sh -e {0}
From https://github.com/libcdio/libcdio-paranoia
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> origin/master
diff --git a/src/cd-paranoia.c b/src/cd-paranoia.c
index 2a6232c..e5df934 100644
--- a/src/cd-paranoia.c
+++ b/src/cd-paranoia.c
@@ -643,7 +643,7 @@ static void cleanup(void) {
   }
   if (reportfile_open) {
     if (reportfile)
-       fclose(reportfile);
+      fclose(reportfile);
     reportfile = NULL;
   }
 }
Error: Process completed with exit code 1.

@adrianreber adrianreber force-pushed the 2024-12-30-clang-format branch 2 times, most recently from 9a0ecae to 1b16d70 Compare December 30, 2024 14:00
@adrianreber adrianreber marked this pull request as ready for review December 30, 2024 14:00
@rocky
Copy link
Collaborator

rocky commented Dec 30, 2024

Thanks. We should probably do likewise in libcdio. A new release of that will be coming up soon.

@rocky rocky merged commit 717f126 into libcdio:master Dec 30, 2024
2 checks passed
@adrianreber adrianreber deleted the 2024-12-30-clang-format branch December 31, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants