Skip to content

Fix CMake minimum version in test/C to unblock macOS CI#281

Merged
grzanka merged 2 commits intomasterfrom
copilot/fix-automatic-tests-failure
Feb 24, 2026
Merged

Fix CMake minimum version in test/C to unblock macOS CI#281
grzanka merged 2 commits intomasterfrom
copilot/fix-automatic-tests-failure

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

macOS CI fails because newer CMake dropped compatibility with cmake_minimum_required versions below 3.5, and test/C/CMakeLists.txt was declaring VERSION 3.2.

Change

  • test/C/CMakeLists.txt: Bump cmake_minimum_required from 3.23.5
# before
cmake_minimum_required(VERSION 3.2)

# after
cmake_minimum_required(VERSION 3.5)
Original prompt

This section details on the original issue you should resolve

<issue_title>Automatic tests are failing</issue_title>
<issue_description>Fails on MacOSX:

-- The C compiler identification is AppleClang 17.0.0.17000013
-- The CXX compiler identification is AppleClang 17.0.0.17000013
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building libamtrack version 0.14.0+45-g8013279
-- Found GSL: /opt/homebrew/Cellar/gsl/2.8/include (found version "2.8")
CMake Error at test/C/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.
-- Configuring incomplete, errors occurred!

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


Error: Process completed with exit code 1.
```</issue_description>

<agent_instructions>Cross check CI configuration for MacOSX, check also CMAKe stuff</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: grzanka <7374733+grzanka@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix automatic tests failing on MacOSX Fix CMake minimum version in test/C to unblock macOS CI Feb 24, 2026
Copilot AI requested a review from grzanka February 24, 2026 06:50
@grzanka grzanka marked this pull request as ready for review February 24, 2026 06:55
@grzanka grzanka requested a review from Copilot February 24, 2026 06:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unblocks macOS CI by updating the standalone C test project’s CMake minimum required version to a level supported by newer CMake releases.

Changes:

  • Bump cmake_minimum_required in test/C/CMakeLists.txt from 3.2 to 3.5 to avoid configuration failure on newer CMake versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@grzanka grzanka merged commit 910c837 into master Feb 24, 2026
8 checks passed
@grzanka grzanka deleted the copilot/fix-automatic-tests-failure branch February 24, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic tests are failing

3 participants