publisher: Errf -> InfoObject #8561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Err logs wind up in audit log, Info doesn't At the same time, move the relevant lines to InfoObject.
mcpherrinm
reviewed
Jan 13, 2026
| if !ok { | ||
| err := fmt.Errorf("No issuerBundle matching issuerNameID: %d", int64(id)) | ||
| pub.log.Errf("Failed to submit certificate to CT log: %s", err) | ||
| pub.log.InfoObject("No configured issuer matches cert", struct { |
Contributor
There was a problem hiding this comment.
This indicates a misconfiguration, and seems like it should stay at error level
aarongable
approved these changes
Jan 13, 2026
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM modulo Matt's comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Err logs wind up in audit log, Info doesn't. At the same time, move the relevant lines to InfoObject.
Also, take the existing info-level logs about error backoffs and move them to no-ops.
Fixes #8431