Merged
Conversation
- Recheck stage now respects $SkipSQLServiceCheck parameter instead of hardcoding $false - Remove unused $Timeout param from Invoke-UpdateCheck remote scriptblock and its ArgumentList since it was never used - Add null guard for $logFilePath in outer catch block - Fix author field to match repository convention Closes #4 Closes #5
…aintenance Fix: correct Recheck stage SQL check and remove unused Timeout param
…ance - Move $null to left side of comparisons (PSPossibleIncorrectComparisonWithNull) - Rename Get-SQLServerServices -> Get-SQLServerService (PSUseSingularNouns) - Rename Invoke-FinalizeUpdates -> Invoke-FinalizeUpdate (PSUseSingularNouns) - Remove unused TimeoutMinutes param from Invoke-UpdateCheck and WSUSTimeoutMinutes from script params (PSReviewUnusedParameter) - Add [CmdletBinding(SupportsShouldProcess)] to Invoke-ServerReboot (PSShouldProcess) - Suppress PSUseUsingScopeModifierInNewRunspaces on Invoke-FinalizeUpdate (uses -ArgumentList pattern)
… level Function-level SuppressMessage does not work for this rule as PSScriptAnalyzer evaluates it at the ScriptBlock scope. Moving the suppression to the script-level param block with justification that variables are passed via -ArgumentList and param() block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.