Fix: parameterize SMTP config and standardize Send-PasswordExpiryNotification#11
Merged
leonardokr merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
…fication - Convert hardcoded SMTP server (x.x.x.x), FromAddress, and SearchBase to mandatory parameters - Add CmdletBinding(SupportsShouldProcess) for consistency with other scripts - Convert all parameters to PascalCase (SearchBase, TestMode, EnableLogging, etc.) matching repository convention - Add new parameters: ExpireInDays, TestRecipient, LogDirectory, Language with proper validation - Remove redundant Import-Module (already handled by #Requires) - Remove unnecessary switch-to-bool intermediate variables - Add Creation Date to .NOTES for consistency Closes #6
leonardokr
force-pushed
the
fix/issue-6-password-expiry-notification
branch
from
85a7f2a to
4b337b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[CmdletBinding(SupportsShouldProcess)]for consistencyImport-Module(handled by#Requires)Closes #6