1st ver #47
Open
1st ver #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeapskeap
reviewed
Nov 29, 2023
There was a problem hiding this comment.
советую больше внимания уделять неймингу, это прям важная хрень
например в 1 задании имя one_day лучше будет передавать смысл переменной delta
ну и для days_30 тоже можно придумать лучшее имя
кстати, только сейчас заметил, что PR сделан в основной репозиторий
| from datetime import timedelta | ||
|
|
||
|
|
||
| def print_days(): |
| print(today, yesterday, days_30) | ||
|
|
||
|
|
||
| def str_2_datetime(date_string): |
skeapskeap
approved these changes
Nov 29, 2023
Co-authored-by: skeapskeap <65304485+skeapskeap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.