finished work #130
Open
finished work #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2023 21:46
krepysh
suggested changes
Feb 23, 2023
2_if2.py
Outdated
| return 3 | ||
| elif len(str_1) > len(str_2): | ||
| return 2 | ||
| else: |
There was a problem hiding this comment.
Если убрать блок else и делать после if return, у нас порядок исполнения кода не поменяется, а код станет чуть проще (менее вложенный, меньше блоков)
3_for.py
Outdated
| a_sale += 1 | ||
| total_sales += sale | ||
| average_sales += 1 | ||
| print(f'суммарное количество продаж {phone}: {total_sales}, среднее количество продаж {phone}: {total_sales // average_sales}') |
There was a problem hiding this comment.
Как правило большого пальца, давай будем разделять "посчитать", "подготовить сообщение" и вывести.
Давай сделаем так что бы функция возвращала набор чисел
return phone, total_sales, average_sale
3_for.py
Outdated
|
|
||
| def main(sales_figures): | ||
| total_sales = average_sales = 0 | ||
| for i in sales_figures: |
There was a problem hiding this comment.
Все что в for происходит можно вынести отдельную функцию
3_for.py
Outdated
| pass | ||
|
|
||
| def main(sales_figures): | ||
| total_sales = average_sales = 0 |
There was a problem hiding this comment.
Более привычный вариант
Suggested change
| total_sales = average_sales = 0 | |
| total_sales, average_sales = 0, 0 |
7_exception2.py
Outdated
| max_discount = abs(int(max_discount)) | ||
| if max_discount >= 100: | ||
| raise ValueError('Слишком большая максимальная скидка') | ||
| if discount >= max_discount: |
There was a problem hiding this comment.
я бы ожидал тут не строгое неравенство, что бы 20 процентов можно было использовать.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.