level_2 #3
Open
level_2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melevir
reviewed
Sep 18, 2023
| products = [] | ||
| # код писать тут | ||
| for product in PRODUCTS: | ||
| type = request.GET.get('type') |
Contributor
There was a problem hiding this comment.
type – это билдин-функция, не надо так называть переменную
| def get_products_view(request): | ||
| products = [] | ||
| # код писать тут | ||
| for product in PRODUCTS: |
Contributor
There was a problem hiding this comment.
Если тип продукта не указан, от цикла вообще можно избавиться. Совсем идеально было бы тут использовать лист компрехеншн.
| if request.method == 'POST': | ||
| data = json.loads(request.body) | ||
| # код писать тут | ||
| print(data) |
| data = json.loads(request.body) | ||
| # код писать тут | ||
| print(data) | ||
| for username, password in USERNAME_TO_PASSWORD_MAPPER.items(): |
Contributor
There was a problem hiding this comment.
Если в словаре пользователей будет много элементов, каждый раз придётся итерироваться по всем. Попробуй переписать так, чтобы этого цикла не было.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.