Improved dev tracing P1 #1993
Open
Improved dev tracing P1 #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
reviewed
Dec 1, 2025
| return docResult.value.documentUuid | ||
| } catch { | ||
| return undefined | ||
| } |
andresgutgon
reviewed
Dec 1, 2025
| @@ -0,0 +1 @@ | |||
| export { NormalizingSpanProcessor } from './normalize' | |||
Contributor
There was a problem hiding this comment.
Do we need to hace this barrel file?
learningbizz
reviewed
Dec 1, 2025
| (attributes['latitude.commitUuid'] as string) || HEAD_COMMIT | ||
|
|
||
| // If promptPath is provided but promptUuid is not, resolve it | ||
| if (promptPath && !promptUuid && projectId) { |
Contributor
There was a problem hiding this comment.
nitpick: instead of a comment and the logic in the if, create a constant with a readable name and add it to the if
learningbizz
reviewed
Dec 1, 2025
| db: typeof database | ||
| }): Promise<string | undefined> { | ||
| try { | ||
| // Get the commit |
Contributor
There was a problem hiding this comment.
no need for this comment, its self explanatory
learningbizz
reviewed
Dec 1, 2025
| } | ||
| const commit = commitResult.value | ||
|
|
||
| // Get the document by path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
telemetry.trace(...)wrapper callback from the Demo Day.Note: This will NOT be the final callback look. That's why this PR doesn't include any documentation or package bump.
HoweverNonetheless, the next changes involve many files so I'd rather do the PR incrementally.Part 1/?