Conversation
brryan
left a comment
There was a problem hiding this comment.
Great work! I can provide comparison data for the particle pushes soon. A lot of this can be done in a unit test, but ultimately I think it would be good to compare particles that have been pushed through the driver, to ensure that driver stages are interacting appropriately with the particle pushes. In that case a purpose-specific pgen that creates a few initial particles and then outputs particle positions with particle IO may be the right choice.
Yurlungur
left a comment
There was a problem hiding this comment.
Nice work! As @brryan suggested, this is probably something we should be integrating more tightly with the geometry package, so that nothing here needs to be recalculated when there are symmetries. But that can be a future improvement.
This PR adds calculations for
k_musource terms (radiation/geodesics.hpp) for arbitrary metric/geometry as it was previously specialized to Minkowski. This was causing unphysical positions when running the torus problem. It now runs beyond the problem point and a longer run in in the queue. Theleptoneqproblem seems reasonable.Also removes a print statement from
plot_snap2dthat I left from before.TODO: