Skip to content

Conversation

@joshprlx
Copy link
Contributor

@joshprlx joshprlx commented Sep 1, 2025

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code (kinda?)
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

@netlify
Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for lando-postgres ready!

Name Link
🔨 Latest commit 311a6b2
🔍 Latest deploy log https://app.netlify.com/projects/lando-postgres/deploys/68b5d1ed2a23cd000806ac3f
😎 Deploy Preview https://deploy-preview-57--lando-postgres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 64 (🔴 down 21 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@joshprlx
Copy link
Contributor Author

joshprlx commented Sep 1, 2025

Ah, I tried an empty commit to get checks to run, but looks like they all run on PR creation

@joshprlx
Copy link
Contributor Author

joshprlx commented Sep 2, 2025

I'm happy to resolve any issues that checks flag up, just not sure how to get those to run 😅

I didn't create an issue for this since this isn't fixing a bug it's just adding a new version, but I'm happy to create an issue if needs be

And I'm not sure who the relevant people to ping are, other than the co-founders but I assume they're hella busy

@AaronFeledy
Copy link
Member

Normally I get a big "approve" button here to kick off the Actions workflows, but something seems to be broken. Either way, I was able to manually start them, so they're running in the "Actions" tab.

@joshprlx
Copy link
Contributor Author

joshprlx commented Sep 4, 2025

Hmmm... so the docs tests are failing in github actions, but the command it's failing on works fine for me locally

npm run docs:mvb

> @lando/postgres@1.5.0 docs:mvb
> npx mvb docs

found site Lando PostgreSQL Plugin at /Users/josh/Code/OpenSource/lando-postgres/docs
setting up mvb build environment using /Users/josh/Code/OpenSource/lando-postgres...
primary build at /plugins/postgres/ using alias dev, ref postgres-17
1 versioned builds at /plugins/postgres/v/
2 builds queued up!

building version dev, ref postgres-17, from docs to docs/.vitepress/dist/...
building version dev, ref postgres-17, from docs to docs/.vitepress/dist/v/dev/...

completed 2 builds at /Users/josh/Code/OpenSource/lando-postgres/docs/.vitepress/dist!

Any idea what's wrong there @AaronFeledy ?

@pirog
Copy link
Member

pirog commented Sep 8, 2025

not sure why the tests didnt run but i was able to manually start them

@pirog pirog merged commit e6c71ab into lando:main Sep 8, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants