Fixed bug with literal parsing #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubkon
requested changes
Jun 24, 2025
Owner
kubkon
left a comment
kubkon
left a comment
There was a problem hiding this comment.
Could you add a matching test(s) please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix tokenizing literals
This is a re-submission of a previous pull request on a clean branch.
Bug fix for issue raised in #87 regarding strings terminating early due to internal quotation marks. this change passes all tests including the test included in the issue. I have not included the additional test in this PR.
The small fix involves removing some terminator characters that should only be relevant before the literal begins, not during. String handling is dealt with elsewhere and should not be relevant once we are dealing with a literal.
current behavior
this is currently parsed as
new behavior
this is now parsed as