-
Notifications
You must be signed in to change notification settings - Fork 28
test(): Added unit tests for pkg/manifest/egress.go file #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alokzh
wants to merge
2
commits into
kubeslice:master
Choose a base branch
from
Alokzh:tests-pkg/manifest/egress
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| /* | ||
| * Copyright (c) 2022 Avesha, Inc. All rights reserved. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package manifest_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "os" | ||
|
|
||
| "github.com/kubeslice/worker-operator/api/v1beta1" | ||
| "github.com/kubeslice/worker-operator/pkg/manifest" | ||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| istiov1beta1 "istio.io/client-go/pkg/apis/networking/v1beta1" | ||
| appsv1 "k8s.io/api/apps/v1" | ||
| corev1 "k8s.io/api/core/v1" | ||
| rbacv1 "k8s.io/api/rbac/v1" | ||
| "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | ||
| ) | ||
|
|
||
| var _ = Describe("Egress Manifest", func() { | ||
| var ( | ||
| ctx context.Context | ||
| fakeClient client.Client | ||
| slice *v1beta1.Slice | ||
| scheme *runtime.Scheme | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| ctx = context.Background() | ||
|
|
||
| scheme = runtime.NewScheme() | ||
| _ = v1beta1.AddToScheme(scheme) | ||
| _ = appsv1.AddToScheme(scheme) | ||
| _ = corev1.AddToScheme(scheme) | ||
| _ = rbacv1.AddToScheme(scheme) | ||
| _ = istiov1beta1.AddToScheme(scheme) | ||
|
|
||
| fakeClient = fake.NewClientBuilder(). | ||
| WithScheme(scheme). | ||
| Build() | ||
|
|
||
| slice = &v1beta1.Slice{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "green", | ||
| Namespace: "kubeslice-system", | ||
| UID: types.UID("test-uid"), | ||
| }, | ||
| } | ||
| }) | ||
|
|
||
| Context("With InstallEgress function", func() { | ||
| It("Should install all egress resources successfully in the slice", func() { | ||
| err := manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| deploy := &appsv1.Deployment{} | ||
| err = fakeClient.Get(ctx, types.NamespacedName{ | ||
| Name: "green-istio-egressgateway", | ||
| Namespace: "kubeslice-system", | ||
| }, deploy) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(deploy.ObjectMeta.Name).Should(Equal("green-istio-egressgateway")) | ||
| }) | ||
|
|
||
| It("Should set controller reference on created resources", func() { | ||
| err := manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| deploy := &appsv1.Deployment{} | ||
| err = fakeClient.Get(ctx, types.NamespacedName{ | ||
| Name: "green-istio-egressgateway", | ||
| Namespace: "kubeslice-system", | ||
| }, deploy) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(deploy.OwnerReferences).ToNot(BeEmpty()) | ||
| Expect(deploy.OwnerReferences[0].UID).To(Equal(slice.UID)) | ||
| }) | ||
|
|
||
| It("Should use custom istio proxy image when environment variable is set", func() { | ||
| customImage := "custom/istio-proxy:1.17.0" | ||
| os.Setenv("AVESHA_ISTIO_PROXY_IMAGE", customImage) | ||
| defer os.Unsetenv("AVESHA_ISTIO_PROXY_IMAGE") | ||
|
|
||
| err := manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| deploy := &appsv1.Deployment{} | ||
| err = fakeClient.Get(ctx, types.NamespacedName{ | ||
| Name: "green-istio-egressgateway", | ||
| Namespace: "kubeslice-system", | ||
| }, deploy) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(deploy.Spec.Template.Spec.Containers[0].Image).To(Equal(customImage)) | ||
| }) | ||
|
|
||
| It("Should use default image when no environment variable is set", func() { | ||
| os.Unsetenv("AVESHA_ISTIO_PROXY_IMAGE") | ||
|
|
||
| err := manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| deploy := &appsv1.Deployment{} | ||
| err = fakeClient.Get(ctx, types.NamespacedName{ | ||
| Name: "green-istio-egressgateway", | ||
| Namespace: "kubeslice-system", | ||
| }, deploy) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(deploy.Spec.Template.Spec.Containers[0].Image).To(Equal(manifest.ISTIO_PROXY_DEFAULT_IMAGE)) | ||
| }) | ||
|
|
||
| It("Should handle already existing resources gracefully", func() { | ||
| err := manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
| }) | ||
|
|
||
| Context("With UninstallEgress function", func() { | ||
| BeforeEach(func() { | ||
| err := manifest.InstallEgress(ctx, fakeClient, slice) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| It("Should uninstall all egress resources successfully from the slice", func() { | ||
| err := manifest.UninstallEgress(ctx, fakeClient, "green") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| deploy := &appsv1.Deployment{} | ||
| err = fakeClient.Get(ctx, types.NamespacedName{ | ||
| Name: "green-istio-egressgateway", | ||
| Namespace: "kubeslice-system", | ||
| }, deploy) | ||
| Expect(errors.IsNotFound(err)).To(BeTrue()) | ||
| }) | ||
|
|
||
| It("Should handle already deleted resources gracefully", func() { | ||
| err := manifest.UninstallEgress(ctx, fakeClient, "green") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = manifest.UninstallEgress(ctx, fakeClient, "green") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.