test(): Added unit test for pkg/cluster/node.go file#439
Open
Alokzh wants to merge 1 commit intokubeslice:masterfrom
Open
test(): Added unit test for pkg/cluster/node.go file#439Alokzh wants to merge 1 commit intokubeslice:masterfrom
Alokzh wants to merge 1 commit intokubeslice:masterfrom
Conversation
Signed-off-by: Alokzh <zhalok24@gmail.com>
gourishkb
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces comprehensive unit tests for the node IP discovery logic located in the pkg/cluster package.
How Has This Been Tested?
The new functionality has been validated through local unit testing
The new tests for
GetNodeIPverify several key scenarios, including:ExternalIPtoInternalIPChecklist:
go fmtDoes this PR introduce a breaking change?