fix(): Added gRPC port configuration & updated sidecar container SecurityContext#436
Open
Alokzh wants to merge 1 commit intokubeslice:masterfrom
Open
fix(): Added gRPC port configuration & updated sidecar container SecurityContext#436Alokzh wants to merge 1 commit intokubeslice:masterfrom
Alokzh wants to merge 1 commit intokubeslice:masterfrom
Conversation
…ity context Signed-off-by: Alokzh <zhalok24@gmail.com>
Contributor
|
@gourishkb please review the PR. |
gourishkb
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing ContainerPorts in the sidecar container spec & updated sidecar container SecurityContext
Fixes #361 #362
Changes:
Drop: ["ALL"])How Has This Been Tested?
Tested with KubeSlice minimal-demo setup. Verified that Sidecar containrs now properly expose gRPC port (5000) & sidecar container SecurityContext requests only needed permissions
Checklist:
go fmtDoes this PR introduce a breaking change?