Skip to content

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Dec 5, 2025

/triage accepted
/kind cleanup
/priority backlog
/cc @cpanato @strongjz @tao12345666333

Copilot AI review requested due to automatic review settings December 5, 2025 22:38
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 5, 2025
@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for kubernetes-ingress-nginx failed. Why did it fail? →

Name Link
🔨 Latest commit e52b8c4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/6936f0d4ca0ad60007f33f47

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/docs approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request bumps the Alpine Linux base image version from 3.22.2 to 3.23.0 across all Dockerfiles and configuration files in the ingress-nginx project. This is a routine maintenance update to keep the base images current with the latest stable Alpine release.

  • Updated all direct Alpine image references from alpine:3.22.2 to alpine:3.23.0
  • Updated all Golang Alpine variant references from alpine3.22 to alpine3.23
  • Updated example/documentation files to reflect the new version

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/e2e-image/Dockerfile Updated base Alpine image to 3.23.0 for E2E test image
rootfs/Dockerfile-chroot Updated base Alpine image to 3.23.0 for chroot environment
images/test-runner/rootfs/Dockerfile Updated Golang Alpine variant to alpine3.23
images/nginx/rootfs/Dockerfile Updated both builder and runtime Alpine images to 3.23.0
images/go-grpc-greeter-server/rootfs/Dockerfile Updated Golang Alpine variant to alpine3.23 for build stage
images/fastcgi-helloserver/rootfs/Dockerfile Updated Golang Alpine variant to alpine3.23 for builder
images/ext-auth-example-authsvc/rootfs/Dockerfile Updated Golang Alpine variant to alpine3.23 for builder
images/custom-error-pages/rootfs/Dockerfile Updated Golang Alpine variant to alpine3.23 for builder
images/cfssl/rootfs/Dockerfile Updated base Alpine image to 3.23.0
docs/examples/customization/sysctl/patch.json Updated Alpine image reference in example configuration to 3.23.0
Makefile Updated E2E_IMAGE Golang Alpine variant to alpine3.23

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Gacko
Copy link
Member Author

Gacko commented Dec 5, 2025

Requires this to be merged first, since there is no Go v1.25.4 image based on Alpine v3.23.0, but only a Go v1.25.5 one.

@Gacko
Copy link
Member Author

Gacko commented Dec 8, 2025

@cpanato: I had to update OpenTelemetry to make the NGINX base image build work. See this diff: https://github.com/kubernetes/ingress-nginx/compare/87975d2858cfe27eeef393051781b54ed4d2f759..5a2160432c0987a70b7c697f4642327b7f15c8c2.

Since you already LGTM'd this, I'm gonna self-LGTM / force-merge once CI succeeds. Just so you know! 🙂

@cpanato
Copy link
Member

cpanato commented Dec 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2025
@Gacko Gacko added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@Gacko Gacko merged commit b33b024 into kubernetes:main Dec 8, 2025
44 of 49 checks passed
@Gacko Gacko deleted the nutsr branch December 8, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants