feat: add a controller to label Nodes with PD compatibility labels #2257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces a new component
gce-pd-node-labeler. It's a controller implemented withcontroller-runtime, which automatically labels Nodes with PD labels. The source of truth is a ConfigMap that can be configured with--configmap-nameand--configmap-namespaceflags.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Sharing for early reviews. I'll look into kustomize next.
Re. testing, I've verified with a k8s-on-gce cluster with 2 gen2 nodes and 2 gen4 nodes:
Add a configmap (not actually SoT):
Build the container image and add this component as a sidecar in the
csi-gce-pd-controller:And verify that the labels are added.
Does this PR introduce a user-facing change?: