This repository was archived by the owner on Jun 24, 2024. It is now read-only.
Open
Conversation
bool is a Python keyword and cannot be added as a --filter without infinite recursion
ghost
reviewed
Oct 8, 2020
| renderer.register_filters({ | ||
| 'docker_link': filters.docker_link, | ||
| 'env': filters.env, | ||
| 'bool': bool, |
Author
There was a problem hiding this comment.
👍 how about both bool and toBool? My application of j2cli is using it to format Ansible jinja, and my existing templates all use bool :)
There was a problem hiding this comment.
I would say, bool is a builtin data type so in the future if we add more stuff around the same filter then it will be easier to handle the stuff with a diff name.
SgtPooki
reviewed
Jan 29, 2021
| renderer.register_filters({ | ||
| 'docker_link': filters.docker_link, | ||
| 'env': filters.env, | ||
| 'bool': bool, |
There was a problem hiding this comment.
Can you also update the docs/README with this PR?
You should update docs anytime you change code; especially when changing a public interface. This PR seems very low-effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bool is a Python keyword and cannot be added as a --filter without infinite recursion