Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Oct 5, 2025

Changes

  • 🧹 Remove the use of old go scaffolding with pack builder

/kind cleanup
Fixes #3005

@knative-prow
Copy link

knative-prow bot commented Oct 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 5, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from dsimansk October 5, 2025 13:49
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2025
@knative-prow knative-prow bot requested a review from nainaz October 5, 2025 13:49
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2025
@gauron99 gauron99 removed request for dsimansk and nainaz October 5, 2025 13:49
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 59.32203% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.83%. Comparing base (a23f6d8) to head (11093ef).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 35.29% 20 Missing and 2 partials ⚠️
pkg/k8s/dialer.go 50.00% 1 Missing ⚠️
pkg/pipelines/tekton/tasks.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
+ Coverage   51.82%   51.83%   +0.01%     
==========================================
  Files         162      162              
  Lines       19131    19188      +57     
==========================================
+ Hits         9914     9947      +33     
- Misses       8240     8262      +22     
- Partials      977      979       +2     
Flag Coverage Δ
integration 17.96% <41.02%> (+0.05%) ⬆️
unit macos-14 44.36% <41.02%> (-0.01%) ⬇️
unit macos-latest 44.36% <41.02%> (-0.01%) ⬇️
unit ubuntu-24.04-arm 44.56% <45.76%> (+0.01%) ⬆️
unit ubuntu-latest 45.30% <41.02%> (-0.02%) ⬇️
unit windows-latest 44.39% <41.02%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 changed the title feat: use upstream scaffolding for go [WIP]feat: use upstream scaffolding for go Oct 5, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 5 times, most recently from c52d5e4 to b4a4209 Compare October 8, 2025 07:22
@gauron99 gauron99 closed this Oct 8, 2025
@gauron99 gauron99 reopened this Oct 8, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 2 times, most recently from 535b772 to ba44af4 Compare October 12, 2025 07:01
@gauron99 gauron99 closed this Oct 12, 2025
@gauron99 gauron99 reopened this Oct 12, 2025
@gauron99 gauron99 closed this Oct 12, 2025
@gauron99 gauron99 reopened this Oct 12, 2025
@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 4 times, most recently from 14a8c20 to 460913a Compare October 14, 2025 09:53
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2025
@gauron99 gauron99 closed this Nov 2, 2025
@gauron99 gauron99 reopened this Nov 2, 2025
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2025
@gauron99 gauron99 closed this Nov 10, 2025
@gauron99 gauron99 reopened this Nov 10, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025
@gauron99
Copy link
Contributor Author

/retest

@gauron99 gauron99 closed this Nov 13, 2025
@gauron99 gauron99 reopened this Nov 13, 2025
@gauron99 gauron99 closed this Nov 13, 2025
@gauron99 gauron99 reopened this Nov 13, 2025
@gauron99 gauron99 closed this Nov 18, 2025
@gauron99 gauron99 reopened this Nov 18, 2025
@gauron99 gauron99 closed this Nov 18, 2025
@gauron99 gauron99 reopened this Nov 18, 2025
@gauron99
Copy link
Contributor Author

/retest

@gauron99
Copy link
Contributor Author

/test all

@gauron99 gauron99 force-pushed the push-psnyzwkrzvkp branch 5 times, most recently from 2dc7ada to 8c709e4 Compare November 21, 2025 10:20
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2025
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire our custom go buildpacks + scaffolding

2 participants